Make optional fields optional in MappingGenericProperty (#703)
#708
Conversation
alex-at-cascade
requested review from
ananzh,
kavilla,
dblock,
VachaShah,
nhtruong,
harshavamsi and
timursaurus
as code owners
|
Thanks, @alex-at-cascade |
If you look at the commit message, it seems to have the proper line - is the automation confused because I used my real name there (instead of my github username)? The contributing guide does say "please use your real name" for that line. |
|
I believe it's expecting your github user name:
|
But https://github.com/opensearch-project/opensearch-js/blob/main/CONTRIBUTING.md says very clearly:
Is that guide inaccurate? (I just want to do the right thing here.) |
|
@alex-at-cascade Hey sorry for the late response. I was out the last few days. You're correct. However the DCO is based off of your github info. In this case, your email address already reflects your name. You can also update your github account to your real name. The goal of the DCO is helping us identifying the contributor, and I think yours is satisfactory :) |
…-project#703) Signed-off-by: alex-at-cascade <alex.dommasch@cascadeenergy.com>
Description
Make optional fields optional in
MappingGenericPropertyIssues Resolved
#703
Check List
yarn run lintdoesn't show any errorsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.